Skip to content

ci: pin PyPI publisher action by commit - #499

Merged
codeforester merged 2 commits into
mainfrom
ci/485-20261028-pin-release-actions
Oct 28, 2026
Merged

codeforester merged 2 commits into
mainfrom
ci/485-20261028-pin-release-actions

Conversation

@codeforester

Copy link
Copy Markdown
Contributor

Summary

  • pin both PyPI/TestPyPI publisher steps to the reviewed v1.14.3 commit
  • update the package workflow regression test to require the expected pin
  • add a guard that rejects non-SHA action references in the release workflow

Security rationale

The release workflow is privileged and must not execute a mutable action tag. The v1.14.3 tag resolves to 7245906fb61fa33a13554f9d5fb856fe61758086; the version comment remains visible for Dependabot and maintainer updates.

Validation

  • UV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra dev pytest -q tests/test_package_workflow.py
  • git diff --check

Relates to #485.

Comment thread tests/test_package_workflow.py Resolved
@codeforester

Copy link
Copy Markdown
Contributor Author

Implemented the review follow-up in commit f317ad82.

  • The regression test now scans every .github/workflows/*.yml file, not just package.yml, and fails if any third-party action is not pinned to a full 40-character commit SHA.

@codeforester
codeforester force-pushed the ci/485-20261028-pin-release-actions branch from f317ad8 to 3cc2783 Compare October 28, 2026 15:14
@codeforester
codeforester merged commit 50ca096 into main Oct 28, 2026
118 checks passed
@codeforester
codeforester deleted the ci/485-20261028-pin-release-actions branch October 28, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant